Fix the example: remove api token error when we fetch recipes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarmen
changed the title
7 tasks
jparez
requested changes
Sep 26, 2024
example/geny-window.js
Outdated
Comment on lines
157
to
160
| const selectElement = document.querySelector('#listRecipes'); | ||
| // Remove our "warning" select option about an invalid/missing api token. | ||
| selectElement.remove(0); | ||
| const placeholderOption = document.createElement('option'); |
There was a problem hiding this comment.
well play, but the bug is worth that what you detect. Every time the input apitoken loose focus, the recipes list is added to the previous.
This will fix all issues
const selectElement = document.querySelector('#listRecipes');
// Flush select before adding new options
selectElement.innerHTML = '';
const placeholderOption = document.createElement('option');
There was a problem hiding this comment.
well play, but the bug is worth that what you detect. Every time the input apitoken loose focus, the recipes list is added to the previous.
Ah, nice catch! 😅
I've adjusted the fix with your suggestion. Thanks!
caarmen
force-pushed
the
dev/fix-invalid-token-recipe-selection
branch
from
4ee98c0
to
3c696e1
Compare
jparez
approved these changes
Sep 27, 2024
pgivel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a minor bug where we had an error message in the recipe selection list.
Steps to reproduce:
Before:
With the fix:
Type of change
Checklist